keith/WP-Content-Sync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: harden url mapping validation

Browse Source
This commit is contained in:
Keith Solomon
2026-04-26 14:34:44 -05:00
parent 8d7abc8536
commit 4880613b67
4 changed files with 95 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Unit/Url/UrlMappingCollectionTest.php
+22 -5
View File
@@ -21,12 +21,29 @@ class UrlMappingCollectionTest extends TestCase {
new UrlMapping( '', 'https://staging.example.test' );
}
public function test_it_returns_mappings_in_order(): void {
$first = new UrlMapping( 'https://example.test', 'https://staging.example.test' );
$second = new UrlMapping( 'https://cdn.example.test', 'https://cdn.staging.example.test' );
$collection = new UrlMappingCollection( array( $first, $second ) );
public function test_it_rejects_mapping_urls_without_scheme_and_host(): void {
$this->expectException( \InvalidArgumentException::class );
$this->expectExceptionMessage( 'Source and destination URLs must include a scheme and host.' );
self::assertSame( array( $first, $second ), $collection->all() );
new UrlMapping( 'https://', 'https://staging.example.test' );
}
public function test_it_preserves_query_and_fragment_trailing_slashes(): void {
$mapping = new UrlMapping(
'https://example.test/?redirect=/',
'https://staging.example.test/#/'
);
self::assertSame( 'https://example.test?redirect=/', $mapping->sourceUrl() );
self::assertSame( 'https://staging.example.test#/', $mapping->destinationUrl() );
}
public function test_it_returns_mappings_by_longest_source_url_first(): void {
$short = new UrlMapping( 'https://example.test', 'https://staging.example.test' );
$long = new UrlMapping( 'https://example.test/uploads', 'https://staging.example.test/uploads' );
$collection = new UrlMappingCollection( array( $short, $long ) );
self::assertSame( array( $long, $short ), $collection->all() );
}
public function test_it_rejects_non_mapping_items(): void {
tests/bootstrap.php
+13
View File
@@ -125,6 +125,19 @@ if ( ! function_exists( 'esc_url_raw' ) ) {
}
}
if ( ! function_exists( 'wp_parse_url' ) ) {
/**
* Minimal URL parser for unit tests.
*
* @param string $url URL to parse.
* @return array<string, mixed>|false
*/
function wp_parse_url( $url ) {
// phpcs:ignore WordPress.WP.AlternativeFunctions.parse_url_parse_url -- Test stub for WordPress' wp_parse_url().
return parse_url( $url );
}
}
if ( ! function_exists( 'get_option' ) ) {
/**
* Minimal WordPress option reader for unit tests.