keith/BattleForge
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: validate battlefield reachability inputs

Browse Source
This commit is contained in:
Keith Solomon
2026-07-04 15:15:08 -05:00
parent 189be5bc64
commit b789f1b61f
2 changed files with 88 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Unit/Domain/BattlefieldTest.php
+55 -6
View File
@@ -19,6 +19,56 @@ final class BattlefieldTest extends TestCase
new Battlefield(7, 16);
}
public function testItRejectsNonCanonicalTerrainCoordinates(): void
{
$this->expectException(InvalidArgumentException::class);
new Battlefield(8, 8, ['01:0' => Terrain::Forest]);
}
public function testItRejectsMalformedTerrainCoordinates(): void
{
$this->expectException(InvalidArgumentException::class);
new Battlefield(8, 8, ['not-a-coordinate' => Terrain::Forest]);
}
public function testItRejectsInvalidTerrainValues(): void
{
$this->expectException(InvalidArgumentException::class);
$terrain = ['0:0' => 'forest'];
new Battlefield(8, 8, $terrain);
}
public function testReachableRejectsAStartOutsideTheBattlefield(): void
{
$battlefield = new Battlefield(8, 8);
$this->expectException(InvalidArgumentException::class);
$battlefield->reachable(new Position(-1, 0), 2, []);
}
public function testReachableRejectsANegativeBudget(): void
{
$battlefield = new Battlefield(8, 8);
$this->expectException(InvalidArgumentException::class);
$battlefield->reachable(new Position(0, 0), -1, []);
}
public function testReachableRejectsOccupiedPositionsOutsideTheBattlefield(): void
{
$battlefield = new Battlefield(8, 8);
$this->expectException(InvalidArgumentException::class);
$battlefield->reachable(new Position(0, 0), 2, [new Position(8, 0)]);
}
public function testItFindsReachableTilesUsingTerrainCostsAndObstacles(): void
{
$battlefield = new Battlefield(8, 8, [
@@ -34,11 +84,10 @@ final class BattlefieldTest extends TestCase
[new Position(0, 2)],
);
self::assertSame(0, $reachable['0:0']);
self::assertSame(2, $reachable['1:0']);
self::assertSame(2, $reachable['0:1']);
self::assertArrayNotHasKey('2:0', $reachable);
self::assertArrayNotHasKey('1:1', $reachable);
self::assertArrayNotHasKey('0:2', $reachable);
self::assertSame([
'0:0' => 0,
'1:0' => 2,
'0:1' => 2,
], $reachable);
}
}