🐞 fix: Update button styles for improved accessibility and consistency
Sync TODOs with Issues / sync_todos (push) Successful in 6s

This commit is contained in:
Keith Solomon
2026-06-16 18:44:35 -05:00
parent 018ca3a9ae
commit e5f3ac1947
3 changed files with 85 additions and 42 deletions
+57 -14
View File
@@ -18,36 +18,65 @@
* --button-outline-color (fallback is --button-border-color) * --button-outline-color (fallback is --button-border-color)
*/ */
--button-bg: var(--background-image-button-gradient); --button-primary-bg: var(--background-image-button-gradient);
--button-color: var(--color-white); --button-primary-color: var(--color-white);
--button-hover-bg: var(--color-info); --button-primary-border-color: var(--color-secondary);
--button-hover-border-color: var(--button-bg); --button-primary-hover-bg: var(--color-secondary);
--button-hover-color: var(--color-white); --button-primary-hover-border-color: var(--color-secondary);
--button-border-width: 2px; --button-primary-hover-color: var(--color-white);
--button-primary-active-bg: color-mix(in oklch, var(--color-secondary) 84%, var(--color-danger));
--button-primary-active-border-color: color-mix(in oklch, var(--color-secondary) 84%, var(--color-danger));
--button-primary-outline-hover-color: var(--color-white);
--button-primary-shadow-color: color-mix(in oklch, var(--color-secondary) 72%, var(--color-danger));
--button-primary-hover-shadow: 0.25rem 0.25rem 0 var(--button-primary-shadow-color);
--button-primary-active-shadow: none;
--button-primary-radius: 1.25rem 0.25rem 1.25rem 0.25rem;
--button-bg: var(--button-primary-bg);
--button-color: var(--button-primary-color);
--button-hover-bg: var(--button-primary-hover-bg);
--button-hover-border-color: var(--button-primary-hover-border-color);
--button-hover-color: var(--button-primary-hover-color);
--button-active-bg: var(--button-primary-active-bg);
--button-active-border-color: var(--button-primary-active-border-color);
--button-shadow: none;
--button-hover-shadow: var(--button-primary-hover-shadow);
--button-active-shadow: var(--button-primary-active-shadow);
--button-border-width: 3px;
--button-border-style: solid; --button-border-style: solid;
--button-border-color: var(--color-secondary); --button-border-color: var(--button-primary-border-color);
--button-radius: 1.25rem 0.25rem; --button-radius: var(--button-primary-radius);
--button-padding-block: 0.625rem;
--button-padding-inline: 2rem;
--button-font-size: var(--text-18px);
--button-font-weight: 700;
--button-letter-spacing: 0;
} }
.btn, .button, .acf-block-preview .button { .btn, .button, .acf-block-preview .button {
@apply px-8 py-2 min-w-0; @apply min-w-0;
background: var(--button-bg); background: var(--button-bg);
color: var(--button-color); box-shadow: var(--button-shadow);
cursor: pointer; cursor: pointer;
display: inline-block; display: inline-block;
transition: background 200ms, border-color 200ms, color 200ms; transition: background 200ms, border-color 200ms, box-shadow 200ms, color 200ms, transform 200ms;
color: var(--button-color);
&.dark { color: white; }
border-width: var(--button-border-width); border-width: var(--button-border-width);
border-style: var(--button-border-style); border-style: var(--button-border-style);
border-color: var(--button-border-color); border-color: var(--button-border-color);
border-radius: var(--button-radius); border-radius: var(--button-radius);
padding: .5rem 2rem; padding: var(--button-padding-block) var(--button-padding-inline);
text-decoration: none; text-decoration: none;
font-weight: var(--button-font-weight, 600); font-weight: var(--button-font-weight, 600);
font-size: var(--button-font-size, 1rem); font-size: var(--button-font-size, 1rem);
letter-spacing: var(--button-letter-spacing);
line-height: 1.1; line-height: 1.1;
&[data-button-variant="outline"] { &[data-button-variant="outline"] {
@@ -59,7 +88,7 @@
--button-color: var(--button-border-color); --button-color: var(--button-border-color);
--button-hover-border-color: var(--button-border-color); --button-hover-border-color: var(--button-border-color);
--button-hover-color: var(--color-white); --button-hover-color: var(--button-primary-outline-hover-color);
} }
} }
@@ -67,6 +96,7 @@
.btn:hover, .button:hover, .acf-block-preview .button:hover { .btn:hover, .button:hover, .acf-block-preview .button:hover {
background: var(--button-hover-bg); background: var(--button-hover-bg);
border-color: var(--button-hover-border-color); border-color: var(--button-hover-border-color);
box-shadow: var(--button-hover-shadow);
color: var(--button-hover-color); color: var(--button-hover-color);
} }
@@ -77,7 +107,12 @@
outline-offset: calc(var(--button-border-width) * 2); outline-offset: calc(var(--button-border-width) * 2);
} }
.btn:active, .button:active { transform: scale(99%); } .btn:active, .button:active {
background: var(--button-active-bg);
border-color: var(--button-active-border-color);
box-shadow: var(--button-active-shadow);
transform: translate(0.125rem, 0.125rem);
}
/** /**
* Variants * Variants
@@ -115,6 +150,8 @@ x-button:has(.button[data-button-width="full"]) { @apply w-full; }
--button-hover-bg: var(--color-dark); --button-hover-bg: var(--color-dark);
--button-hover-border-color: var(--color-dark); --button-hover-border-color: var(--color-dark);
--button-hover-color: var(--color-white); --button-hover-color: var(--color-white);
--button-active-bg: var(--color-dark);
--button-active-border-color: var(--color-dark);
} }
.btn[data-button-color="light"], .button[data-button-color="light"] { .btn[data-button-color="light"], .button[data-button-color="light"] {
@@ -124,6 +161,8 @@ x-button:has(.button[data-button-width="full"]) { @apply w-full; }
--button-hover-bg: var(--color-dark); --button-hover-bg: var(--color-dark);
--button-hover-border-color: var(--color-dark); --button-hover-border-color: var(--color-dark);
--button-hover-color: var(--color-white); --button-hover-color: var(--color-white);
--button-active-bg: var(--color-dark);
--button-active-border-color: var(--color-dark);
} }
.btn[data-button-color="white"], .button[data-button-color="white"] { .btn[data-button-color="white"], .button[data-button-color="white"] {
@@ -133,6 +172,8 @@ x-button:has(.button[data-button-width="full"]) { @apply w-full; }
--button-hover-bg: var(--color-secondary-200); --button-hover-bg: var(--color-secondary-200);
--button-hover-border-color: var(--color-secondary-200); --button-hover-border-color: var(--color-secondary-200);
--button-hover-color: var(--color-black); --button-hover-color: var(--color-black);
--button-active-bg: var(--color-secondary-200);
--button-active-border-color: var(--color-secondary-200);
} }
.btn[data-button-color="black"], .button[data-button-color="black"] { .btn[data-button-color="black"], .button[data-button-color="black"] {
@@ -142,6 +183,8 @@ x-button:has(.button[data-button-width="full"]) { @apply w-full; }
--button-hover-bg: var(--color-secondary); --button-hover-bg: var(--color-secondary);
--button-hover-border-color: var(--color-secondary); --button-hover-border-color: var(--color-secondary);
--button-hover-color: var(--color-dark); --button-hover-color: var(--color-dark);
--button-active-bg: var(--color-secondary);
--button-active-border-color: var(--color-secondary);
} }
/* Back To Top Button */ /* Back To Top Button */
+1 -1
View File
@@ -41,7 +41,7 @@ $wrapper = blockWrapperAttributes( $classes, $is_preview );
<?php endif; ?> <?php endif; ?>
<?php if ( $button ) : ?> <?php if ( $button ) : ?>
<a class="contact-block__cta button text-white!" href="<?php echo esc_url( $button['url'] ?? '#' ); ?>" title="<?php echo esc_attr( $button['title'] ?? '' ); ?>" aria-label="<?php echo esc_attr( $button['title'] ?? '' ); ?>" data-button-color="secondary" data-button-variant="outline"><?php echo esc_html( $button['title'] ); ?></a> <a class="contact-block__cta button dark" href="<?php echo esc_url( $button['url'] ?? '#' ); ?>" title="<?php echo esc_attr( $button['title'] ?? '' ); ?>" aria-label="<?php echo esc_attr( $button['title'] ?? '' ); ?>" data-button-color="secondary" data-button-variant="outline"><?php echo esc_html( $button['title'] ); ?></a>
<?php endif; ?> <?php endif; ?>
</div> </div>
</section> </section>
+1 -1
View File
@@ -61,7 +61,7 @@ $wrapper = blockWrapperAttributes( $classes, $is_preview );
} }
?> ?>
<x-button <x-button
btnclasses="button text-center min-w-32" btnclasses="button text-center min-w-32 dark"
element="a" element="a"
url="<?php echo esc_url( $ctaURL ); ?>" url="<?php echo esc_url( $ctaURL ); ?>"
target="<?php echo esc_attr( $ctaTarget ); ?>" target="<?php echo esc_attr( $ctaTarget ); ?>"